Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport LogExpFunctions #108

Merged
merged 4 commits into from
Apr 19, 2021
Merged

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Feb 17, 2021

Fixes #46.

The basic log/exp functions were all moved to LogExpFunctions (see #46 (comment)). This PR removes the duplicate implementations in StatsFuns and reexports the definitions in LogExpFunctions.

@tpapp
Copy link
Contributor

tpapp commented Feb 17, 2021

Incidentally, I initiated the repo transfer to JuliaStats, but got no reply. If it somehow expired, I am happy to do it again.

src/StatsFuns.jl Outdated Show resolved Hide resolved
@cossio
Copy link
Contributor

cossio commented Feb 18, 2021

What's holding this up?

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I haven't seen any notification regarding the transfert request. If you make me an owner of the repo I'll do it.

Also, could you preserve the git history from StatsFuns in the new repo? That would be useful.

@tpapp
Copy link
Contributor

tpapp commented Feb 22, 2021

@nalimilan: apparently I need permissions on JuliaStats to make the transfer, can you add me?

I don't know how to preserve the git history.

@nalimilan
Copy link
Member

@nalimilan: apparently I need permissions on JuliaStats to make the transfer, can you add me?

Yes the person doing the transfer needs to be an owner of both source and destination. I've sent you an invitation.

I don't know how to preserve the git history.

See explanations here for example: JuliaLang/julia#31395 (comment)

@tpapp
Copy link
Contributor

tpapp commented Feb 22, 2021

Thanks. I made the transfer, but currently have no time for the git history operation. If anyone wants to do it, please do not hesitate.

@devmotion
Copy link
Member Author

I opened a PR to the registry as well (JuliaRegistries/General#30590), following the instructions in https://github.com/JuliaRegistries/General#how-do-i-transfer-a-package-to-an-organization-or-another-user.

@nalimilan
Copy link
Member

OK, I've run git-filter-repo --path src/basicfuns.jl --path test/basicfuns.jl on the StatsFuns repo, fetched it as a branch in LogSumExpFunctions, rebased master on top of it, and pushed it to the StatsFuns-rebased branch.

But that's not ideal as another commit synced against StatsFuns later so the diff is backwards. So I pushed another StatsFuns-rebased2 branch in which I squashed the few initial commits up to the sync. This gives a much cleaner diff. What do you think? I guess we should keep existing commits somewhere since releases point to them, but we could start from there for the new main?

@devmotion
Copy link
Member Author

I am not sure what's the best approach to keep/transfer some git history. Since there are already releases of LogExpFunctions in the general registry that point to commits in the repo it seems we shouldn't touch the existing commits? So even though I would prefer if the history could be kept, I am not sure if it can be done in a clean way. Maybe one could add a commit that removes all contents in the LogExpFunctions repo, then add a copy of the StatsFuns files, and afterwards re-apply the current commits in the LogExpFunctions repo rebased on the copy (but maybe without the sync commit)?

@devmotion
Copy link
Member Author

devmotion commented Apr 19, 2021

I went for a simpler but less sophisticated approach (i.e. more work 😄): I extracted the git history of the relevant files with git filter-repo and merged it with the updated docstrings in LogExpFunctions manually. This preserves all existing commits and history in LogExpFunctions but also adds the git history from StatsFuns. I opened a PR: JuliaStats/LogExpFunctions.jl#11

@devmotion devmotion merged commit 56322bb into JuliaStats:master Apr 19, 2021
@devmotion devmotion deleted the logexpfunctions branch April 19, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: move log/exp variants to a separate package
4 participants