-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reexport LogExpFunctions #108
Conversation
Incidentally, I initiated the repo transfer to JuliaStats, but got no reply. If it somehow expired, I am happy to do it again. |
What's holding this up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I haven't seen any notification regarding the transfert request. If you make me an owner of the repo I'll do it.
Also, could you preserve the git history from StatsFuns in the new repo? That would be useful.
@nalimilan: apparently I need permissions on JuliaStats to make the transfer, can you add me? I don't know how to preserve the git history. |
Yes the person doing the transfer needs to be an owner of both source and destination. I've sent you an invitation.
See explanations here for example: JuliaLang/julia#31395 (comment) |
Thanks. I made the transfer, but currently have no time for the git history operation. If anyone wants to do it, please do not hesitate. |
I opened a PR to the registry as well (JuliaRegistries/General#30590), following the instructions in https://github.com/JuliaRegistries/General#how-do-i-transfer-a-package-to-an-organization-or-another-user. |
OK, I've run But that's not ideal as another commit synced against StatsFuns later so the diff is backwards. So I pushed another StatsFuns-rebased2 branch in which I squashed the few initial commits up to the sync. This gives a much cleaner diff. What do you think? I guess we should keep existing commits somewhere since releases point to them, but we could start from there for the new main? |
I am not sure what's the best approach to keep/transfer some git history. Since there are already releases of LogExpFunctions in the general registry that point to commits in the repo it seems we shouldn't touch the existing commits? So even though I would prefer if the history could be kept, I am not sure if it can be done in a clean way. Maybe one could add a commit that removes all contents in the LogExpFunctions repo, then add a copy of the StatsFuns files, and afterwards re-apply the current commits in the LogExpFunctions repo rebased on the copy (but maybe without the sync commit)? |
I went for a simpler but less sophisticated approach (i.e. more work 😄): I extracted the git history of the relevant files with |
Fixes #46.
The basic
log
/exp
functions were all moved to LogExpFunctions (see #46 (comment)). This PR removes the duplicate implementations in StatsFuns and reexports the definitions in LogExpFunctions.